Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix tests. #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RajkaranSh
Copy link

Added/modified following in this PR

  • Added a maven library so that the tests can run on Apple macs with M1 chips too. earlier it was failing with docker not found error.
  • Fixed postgres tests for precision variable for decimal types. Have check the values returned from db schema scrawler for precision. It returns precision as 0 for the decimal types where precision is not provided.
  • Added a test for postgresql default string in table create definition. After this test is added the tests failed as the avro generated didn't have default value. This would happen with integer default values also.
  • Fixed above case where default value would be null for default string and default integer cases.

@RajkaranSh
Copy link
Author

@artur-tamazian have added a few tests cases and fixes. please review.
Kindly be gentle with my mistakes as this is my first open source contribution.
Thanks

@artur-tamazian
Copy link
Owner

Sorry for late reply and thank you for contribution! I only have one minor comment above

@RajkaranSh
Copy link
Author

Hi @artur-tamazian, my apologies for the delayed attention to this PR, i can't see your comment in the PR. kindly check and revert. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants