@alloy <= Use Frameworks #520
Conversation
|
Yay, more 🎉 😄
I’m not sure what this means. Is that a bug in CocoaPods? And what is it that we should have been using and what we shouldn’t have been using? |
|
CocoaPods allows accessing Pods' header files individually like |
|
Gotcha, thanks 👍 |
| @@ -344,33 +348,6 @@ - (void)showQuicksilver | |||
| [navigationController pushViewController:adminSettings animated:YES]; | |||
| } | |||
|
|
|||
| - (void)checkForiOS7Deprecation | |||
There was a problem hiding this comment.
compiling for iOS8 now, in theory we could do something similar for ios8 later next year
This makes it so that OSS people will be able to build+run on the simulator without any changes needed to the project (it is needed when they’d want to run on device) and also means the CI server will simply be able to run the tests without any changes.
orta
force-pushed
the
orta-frameworks2
branch
2 times, most recently
from
e2db64c
to
a89b7f6
Compare
|
|
|
ready for review |
Has this been done? And what about on 📱 ? |
|
Otherwise the patch looks good to me 👍 |
Doing it on an iPad ATM in-between eidolon travis runs. 👍 |
|
Confirmed. I can log in to my account via Facebook when running on an iPad in store config 👍 |
|
Alright, I'm doing it. |
|
Awesome 👍 |
I know what you're thinking, "but there's already an unmergable PR for frameworks." Well guess what, there's more. A bug in the de-duplicating version of means that you can't get away with
#import "Pods.h"which meant that I had to ensure we didn't use any of these in our app ( which is what we should be doing anyway ) so I made this PR to give someone a roadmap for when frameworks gets in.This PR totally breaks Facebook login, we really need that auth lib finishedThis has been re-implmented with the new Facebook API, so it will need some manual testing.