Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tasks QA bug fixes #11057

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Tasks QA bug fixes #11057

wants to merge 4 commits into from

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Nov 4, 2024

This PR resolves EMI-2166, EMI-2169, and EMI-2171

Description

This PR fixes 2 issues from the Tasks QA

  • Attempting to fix the onboarding animation
  • Navigate the user to the order details screen instead of the web view (and maybe fix the Android issue of the blank screen)

This PR also adds /orders/:orderID to the routers

Videos

Videos

Before

Android iOS
Tapping tasks
tapping-tasks-android-before.mov
tapping-tasks-ios-before.mov
Send Wire screen
send-wire-android-before.mov
send-wire-ios-before.mov
View Pending Order
view-pending-order-android-before.mov
view-pending-order-ios-before.mov
View Offer
view-offer-android-before.mov
view-offer-ios-before.mov

After

Android iOS
Tapping tasks
tapping-tasks-android-after.mov
tapping-tasks-ios-after.mov
Send Wire screen
send-wire-offer-android-after.mov
send-wire-offer-ios-after.mov
View Pending Order
view-pending-order-android-after.mov
view-pending-order-ios-after.mov
View Offer
view-offer-android-after.mov
view-offer-ios-after.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix tasks onboard animation
  • add order details URL to routes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Nov 4, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (fix tasks onboard animation,add order details URL to routes - MrSltun)

Generated by 🚫 dangerJS against b5fd00e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants