Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMI-2058): use primaryLabel to display Limited-Time Offer badge #10750

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Sep 11, 2024

This PR resolves []

Description

Use primaryLabel to display Limited-Time Offer badge
Use partnerOffer on Artwork instead of Me in the ArtworkPrice component

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • use primary label field for signal badge -daria

Need help with something? Have a look at our docs, or get in touch with us.

@dariakoko
Copy link
Contributor Author

Could someone suggest me how test this change, please? I need some partner offers visible for my account and I have none at the moment. Can I add partner offers to my account somehow?

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (use primary label field for signal badge -daria)

Generated by 🚫 dangerJS against a0124e2

@rquartararo
Copy link
Member

Could someone suggest me how test this change, please? I need some partner offers visible for my account and I have none at the moment. Can I add partner offers to my account somehow?

@dariakoko You will need to like an artwork and then log in as the partner who listed the artwork to create a partner offer. I can walk you through it if you wanna get on a call!

@dariakoko
Copy link
Contributor Author

That would be great, thanks @rquartararo! I'll dm you on slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants