Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limited supply extension factory #77

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

caffeinum
Copy link
Member

@caffeinum caffeinum commented Oct 5, 2022

TODO:

  • refactor factory into one factory
  • make sure both versions of extension have same code
  • [ ]

https://gate-goerli.buildship.xyz/deploy/bafkreidbdmcmt3nvhnztikwmone6abenku4lz75uxljisxchoric5ly2eu?args=%5B%5D

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #77 (9d4716f) into main (8aa4133) will increase coverage by 1.37%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   48.70%   50.08%   +1.37%     
==========================================
  Files          32       35       +3     
  Lines        1162     1198      +36     
  Branches      202      207       +5     
==========================================
+ Hits          566      600      +34     
- Misses        596      598       +2     
Impacted Files Coverage Δ
contracts/extensions/base/LimitedSupply.sol 100.00% <ø> (ø)
contracts/extensions/factories/Allowlist.sol 73.91% <ø> (ø)
...ensions/factories/base/NFTExtensionUpgradeable.sol 57.14% <ø> (ø)
...tensions/factories/base/SaleControlUpgradeable.sol 71.42% <ø> (ø)
.../extensions/factories/factory/AllowlistFactory.sol 100.00% <ø> (ø)
...ts/extensions/factories/LimitedSupplyExtension.sol 88.88% <88.88%> (ø)
...nsions/factories/base/LimitedSupplyUpgradeable.sol 100.00% <100.00%> (ø)
...actories/factory/LimitedSupplyExtensionFactory.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caffeinum caffeinum temporarily deployed to Buildship November 24, 2022 08:06 Inactive
@caffeinum caffeinum temporarily deployed to Buildship November 24, 2022 08:11 Inactive
@caffeinum caffeinum temporarily deployed to Buildship November 24, 2022 08:30 Inactive
@caffeinum caffeinum force-pushed the feature/limited-supply-extension-factory branch from 5785db3 to 9d4716f Compare December 16, 2022 12:50
@caffeinum caffeinum temporarily deployed to Buildship December 16, 2022 12:50 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants