Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NFTExtension Interface Conformance Check in MetaverseNFT #104

Closed
wants to merge 2 commits into from
Closed

Fix NFTExtension Interface Conformance Check in MetaverseNFT #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0eb624
Update INFTExtension interface
Apr 30, 2023
e886032
Modify the addExtension function in MetaverseNFT
Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions contracts/factory/MetaverseNFT.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
function addExtension(address extension) public onlyOwner {
require(!extensionExists[extension], "M:EXTENSION_ALREADY_ADDED");
require(extension != address(this), "M:EXTENSION_CAN_NOT_BE_THIS");
require(extension != address(0), "M:EXTENSION_CAN_NOT_BE_ZERO");
require(
INFTExtension(extension).extensionType() != bytes32(0),
"M:EXTENSION_IS_NOT_NFT_EXTENSION"
);
uint256 id = _extensions.add(extension);
extensionExists[extension] = true;
emit ExtensionAdded(extension, id);
}
5 changes: 5 additions & 0 deletions contracts/factory/extensions/INFTExtension.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pragma solidity ^0.8.0;

interface INFTExtension {
function extensionType() external view returns (string memory);
}