-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
autopr/89
branch
2 times, most recently
from
April 30, 2023 18:28
795007c
to
6bdc76e
Compare
github-actions
bot
changed the title
Fix #89: ERC721Community: can't burn() via Extension with reducing maxSupply
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: ERC721Community: can't burn() via Extension with reducing maxSupply
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: ERC721Community: can't burn() via Extension with reducing maxSupply
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:35
6bdc76e
to
a59cf87
Compare
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
…Implementation.sol
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:36
931b3b8
to
3fcf6d3
Compare
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:39
4f48fe1
to
bccf495
Compare
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:39
bccf495
to
5557b2a
Compare
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
changed the title
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:40
5557b2a
to
b54ee1c
Compare
github-actions
bot
changed the title
Implement BurnExtension to support token burning and reducing maxSupply (#89)
Fix #89: Implement burn() function with reduced maxSupply in ERC721Community contracts
Apr 30, 2023
github-actions
bot
force-pushed
the
autopr/89
branch
from
April 30, 2023 18:41
b54ee1c
to
8dba404
Compare
Please don't copy the file, you can edit file |
Lintrule needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Description
This PR aims to resolve issue #89 by implementing a new burn function in the ERC721Community contracts that updates the contract state and reduces maxSupply when a token is burned. The changes ensure proper integration with OpenSea and prevent the need for BurnExtensions.
Status
This pull request is being autonomously generated by AutoPR.
Progress Updates
✅ Planned pull request
✅ Wrote commit: Analyze burn mechanism in ERC721CommunityBase.sol and ERC721CommunityImplementation.sol
✅ Wrote commit: Modify onlyOwner access modifier for reduceMaxSupply function