Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721Community: can't burn() via Extension with reducing maxSupply #89

Open
theshadowagent opened this issue Nov 10, 2022 · 1 comment
Open

ERC721Community: can't burn() via Extension with reducing maxSupply #89

theshadowagent opened this issue Nov 10, 2022 · 1 comment
Assignees
@caffeinum
Labels
Run AutoPR 🚀

Comments

@theshadowagent
Copy link
Member

theshadowagent commented Nov 10, 2022 •
edited
Loading

ERC721Community contract is based on ERC721A which supports burning only by transferring to 0xdead address (0x000000000000000000000000000000000000dEaD). Such burns don't reduce the number of items on OpenSea, because the contract needs to be updated as well

Writing a BurnExtension with reducing maxSupply is currently not possible because reduceMaxSupply is onlyOwner and doesn't allow burning less than totalMinted() amount
@theshadowagent
Copy link
Member Author

I just realised that reducing maxSupply won't help OpenSea to display correct amount, because it's not part of ERC721 standard and OpenSea doesn't read maxSupply at all

@github-actions github-actions bot mentioned this issue Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caffeinum caffeinum

Labels
Run AutoPR 🚀
Projects
None yet
Milestone
No milestone
2 participants
@caffeinum @theshadowagent