Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #111: Translation History #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0x6362
Copy link
Contributor

@0x6362 0x6362 commented Nov 13, 2024

@artemave: Tried to keep this in the style of the existing code and refactor as little as possible, very much an MVP of the functionality to get your feedback

RE: storage and export. Went with JSON instead of CSV, which possibly less accessible to users by default. Happy to create a setting to support export in either.

Other call out is the addition of the dexie dependency. I would prefer not to implement code for handling IndexedDB migrations/schema changes myself, but I've done it before and can do it here if you would prefer not to add a dep.


  • Adds Setting, defaulting to "On", enabling recording/logging of translated words for later export, e.g. to convert into Anki cards
  • Adds button to the TransOver Popup Window to save history of translated words

TODO

  • Test in Chrome
  • Test in browsers still using v2 Manifest?

@artemave
Copy link
Owner

RE: storage and export. Went with JSON instead of CSV, which possibly less accessible to users by default. Happy to create a setting to support export in either.

Probably best to add CSV as a follow up pr.

@artemave
Copy link
Owner

Other call out is the addition of the dexie dependency

Adding dexie seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants