Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsalan's edits #3

Open
wants to merge 22 commits into
base: comments
Choose a base branch
from
Open

Arsalan's edits #3

wants to merge 22 commits into from

Conversation

arsidada
Copy link
Owner

@arsidada arsidada commented Sep 2, 2018

  • Fixed formatting issues with go fmt and go vet -v
  • Organized code to separate approvals API stuff from comments API
  • Added comments to functions
  • Updated comments API names to be just comments for both GET and POST calls. It's more convenient to use
  • Updated API to not userid but use username instead. When using userid, the front-end app will have to figure out who this ID is by calling the FB or Google auth API and then show the name. This is highly inefficient. Instead if we store the username from when the comment was made, we can just return that when a GET comments call is made
  • Updated comments POST API to accept the content of the comment via Body and not via Header. Using content in headers is against REST best practices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants