Use Triple and Pair in childPanelsWebNavigation for consistency

[arkivanov]

Summary by CodeRabbit

• New Features

  • Enhanced flexibility in navigation with updated childPanelsWebNavigation methods supporting Pair and Triple for serialization.
  • New methods added to PanelsNavigator for improved state management and navigation control.
  • Introduction of DefaultWebHistoryController for advanced web navigation capabilities.
  • Updated childPanels function to support additional serialization for child components.

• Bug Fixes

  • Improved handling of serialization for child components in navigation.

• Documentation

  • Updated documentation for childPanelsWebNavigation overloads to clarify usage distinctions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant modifications to the decompose library, particularly affecting the childPanelsWebNavigation method across various classes. The method has been updated to accept kotlin.Pair and kotlin.Triple as parameters instead of multiple kotlinx.serialization.KSerializer parameters, enhancing flexibility in serialization. Additionally, new methods have been added to the PanelsNavigator interface, and a new class, DefaultWebHistoryController, has been introduced. The changes aim to improve navigation and state management functionalities within the library while maintaining existing structures.

Changes

File Path	Change Summary
decompose/api/android/decompose.api	Updated childPanelsWebNavigation method to accept kotlin.Pair and kotlin.Triple instead of three KSerializer parameters. Added synthetic default methods for backward compatibility.
decompose/api/decompose.klib.api	Modified childPanelsWebNavigation method to accept kotlin.Triple and added overload for kotlin.Pair. New methods added to PanelsNavigator: activateDetails, activateExtra, activateMain, dismissDetails. Introduced DefaultWebHistoryController.
decompose/api/jvm/decompose.api	Similar updates to childPanelsWebNavigation method, changing parameter types to kotlin.Pair and kotlin.Triple. Synthetic default methods updated accordingly.
decompose/src/commonMain/kotlin/com/arkivanov/decompose/router/panels/ChildPanelsFactory.kt	Updated childPanels function signatures to include Triple for serializers, facilitating additional component serialization. Added parameters for saving and restoring panel state.
decompose/src/commonMain/kotlin/com/arkivanov/decompose/router/panels/PanelsWebNavigation.kt	Added overload for childPanelsWebNavigation for two panels, updated existing overload to use Triple for three panels. Documentation updated for clarity on usage.
sample/shared/shared/src/commonMain/kotlin/com/arkivanov/sample/shared/multipane/DefaultMultiPaneComponent.kt	Updated serializers parameter to use a private companion object SERIALIZERS, simplifying method calls in childPanels and childPanelsWebNavigation.

Possibly related PRs

• Added Child Panels navigation model #782: Updates to the childPanelsWebNavigation method to accept kotlin.Pair and kotlin.Triple, directly related to the main PR.
• Use Triple and Pair in childPanelsWebNavigation for consistency #823: This PR focuses on updating the childPanelsWebNavigation method to use kotlin.Pair and kotlin.Triple, which directly relates to the changes made in the main PR regarding the method's parameter types.

🐰 In the land of code, where rabbits play,
New paths of navigation brighten the way.
With pairs and triples, we leap and bound,
In panels and history, new joys are found.
So hop along, dear coder, with glee,
For the decompose library is now fancy and free! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6c9b337 and de71a3a.

📒 Files selected for processing (6)

• decompose/api/android/decompose.api (1 hunks)
• decompose/api/decompose.klib.api (1 hunks)
• decompose/api/jvm/decompose.api (1 hunks)
• decompose/src/commonMain/kotlin/com/arkivanov/decompose/router/panels/ChildPanelsFactory.kt (1 hunks)
• decompose/src/commonMain/kotlin/com/arkivanov/decompose/router/panels/PanelsWebNavigation.kt (4 hunks)
• sample/shared/shared/src/commonMain/kotlin/com/arkivanov/sample/shared/multipane/DefaultMultiPaneComponent.kt (3 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.