Fixed details panel placeholder showing in SINGLE mode

[arkivanov]

Summary by CodeRabbit

• New Features

  • Enhanced handling of empty child panels in the UI, improving the specificity of placeholder display.
  • Introduced overloaded versions of the ChildPanels function for more flexible usage.

• Bug Fixes

  • Refined logic in the DetailsPanel function to conditionally display placeholders based on the specific empty child instance.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the ChildPanels composable functions in the ChildPanels.kt file, enhancing the handling of empty child panels. It includes overloaded versions of the ChildPanels function to accept both Value<ChildPanels<...>> and ChildPanels<...>. The DetailsPanel function's logic is refined to conditionally display placeholders based on the specific empty child instance. The ExtraPanel function remains unchanged but supports the new structure. Overall, the changes focus on improving the conditional rendering of placeholders while maintaining existing documentation and API clarity.

Changes

File Path	Change Summary
extensions-compose-experimental/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/experimental/panels/ChildPanels.kt	- Overloaded ChildPanels functions to accept Value<ChildPanels<...>> and ChildPanels<...> directly. - Updated DetailsPanel to conditionally display placeholders only for EmptyChild3. - ExtraPanel remains unchanged but supports new structure.

Possibly related PRs

• Added placeholders for ChildPanels #811: The changes in this PR involve adding placeholders for ChildPanels, which directly relates to the modifications in the main PR that enhance the handling of empty child panels and refine the logic for displaying placeholders.

Poem

🐇 In the land of panels, bright and wide,
A rabbit hops with joy and pride.
With placeholders now so smart and keen,
Empty child panels are seldom seen!
So let us cheer for changes grand,
In our UI, all perfectly planned! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8387e01 and 20b36ba.

📒 Files selected for processing (1)

• extensions-compose-experimental/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/experimental/panels/ChildPanels.kt (1 hunks)

🔇 Additional comments (1)

extensions-compose-experimental/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/experimental/panels/ChildPanels.kt (1)

323-328: LGTM! Fix correctly handles placeholder visibility

The implementation now properly shows the placeholder only for EmptyChild3 (DUAL/TRIPLE modes), fixing the issue where the placeholder was incorrectly shown in SINGLE mode.

Let's verify the fix handles all modes correctly:

✅ Verification successful

The output confirms that EmptyChild3 is exclusively used in DUAL and TRIPLE modes, while EmptyChild1 is used in SINGLE mode. Let's verify the placeholder-related code to ensure complete correctness:

---

Fix correctly implemented and verified

The verification confirms:

• EmptyChild3 is exclusively used in DUAL and TRIPLE modes
• The placeholder is now conditionally shown only for EmptyChild3
• SINGLE mode uses EmptyChild1 which correctly bypasses the placeholder display
• The implementation maintains proper placeholder behavior for DUAL/TRIPLE modes

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify EmptyChild usage across different modes
# Test: Search for EmptyChild references to confirm correct usage in different modes
rg -A 5 'EmptyChild[1-4]' | grep -E 'SINGLE|DUAL|TRIPLE'

Length of output: 2054

---

Script:

#!/bin/bash
# Search for placeholder-related code and empty child handling
rg -B 2 -A 5 'placeholder\(\)' extensions-compose-experimental/src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/experimental/panels/ChildPanels.kt

Length of output: 506

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.