Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force javaTarget 11 for all non-Android JVM targets #758

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

arkivanov
Copy link
Owner

@arkivanov arkivanov commented Aug 8, 2024

Summary by CodeRabbit

  • Chores
    • Updated the version of the gradle-setup-plugin to enhance build performance and stability.
    • Incremented the version of the essenty dependency to introduce potential bug fixes and improvements.

Copy link

coderabbitai bot commented Aug 8, 2024

Warning

Rate limit exceeded

@arkivanov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 32 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between eb468c7 and b8fd35b.

Walkthrough

The recent changes focus on updating the version of the gradle-setup-plugin in the settings.gradle.kts file, moving from 310f7f6b99 to 1c9e347ca6. This upgrade is expected to bring new features and improvements, while maintaining the existing control flow and logic. Additionally, the essenty dependency version in deps.versions.toml has been incremented from 2.2.0-alpha03 to 2.2.0-alpha04, indicating ongoing development within its alpha release.

Changes

File Change Summary
settings.gradle.kts Updated gradle-setup-plugin version from 310f7f6b99 to 1c9e347ca6.
deps.versions.toml Changed essenty version from 2.2.0-alpha03 to 2.2.0-alpha04.

Poem

🐇 In the meadow, changes bloom,
A plugin's upgrade clears the gloom.
With new features, swift and bright,
Our builds take flight, a joyous sight!
Hops of progress, leaps of cheer,
Let's celebrate another year! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 96ff45e and 8c4042f.

Files selected for processing (1)
  • settings.gradle.kts (1 hunks)
Additional comments not posted (1)
settings.gradle.kts (1)

18-18: Verify the impact of the plugin version update.

The plugin version has been updated from 310f7f6b99 to 1c9e347ca6. Ensure that this update does not introduce any breaking changes or unexpected behavior in the build process.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8c4042f and eb468c7.

Files selected for processing (2)
  • deps.versions.toml (1 hunks)
  • settings.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (1)
  • deps.versions.toml
Files skipped from review as they are similar to previous changes (1)
  • settings.gradle.kts

@arkivanov arkivanov merged commit 14be7b6 into master Aug 8, 2024
2 checks passed
@arkivanov arkivanov deleted the javaTarget-11 branch August 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant