-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCDU を AOS transfer frame に rename する #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
force-pushed
the
feature/rename_vcdu
branch
from
November 8, 2023 10:22
8e0be73
to
ffee48d
Compare
meltingrabbit
changed the title
WIP: VCDU を AOS transfer frame に rename する
VCDU を AOS transfer frame に rename する
Nov 8, 2023
ToshiAki64
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いいと思います。
ただ、rename系の変更になるので、shスクリプトが用意されるのかが、気になり。
user example (mobc) なので sh はなしですかね. cf: #196 |
migration script 作っていいと思いますよ(というか作れるなら作った方がいい) |
meltingrabbit
force-pushed
the
feature/rename_vcdu
branch
from
November 9, 2023 08:49
2139a37
to
17f665c
Compare
meltingrabbit
force-pushed
the
feature/rename_vcdu
branch
from
November 9, 2023 09:04
17f665c
to
aaee9f4
Compare
かわりに丁寧なchangelogかいた |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
rename し,さらにコード規約に合わせた.
ロジックは変えてない(はず)
Issue
詳細
MOBC user 側の修正方法
VCDU
をAOSTF
に置換する(TLM DB の csv なども)vcdu
をaostf
に置換する(TLM DB の csv なども)vcdu.h
をaos_transfer_frame.h
に置換する(include の修正)検証結果
CIがとおればOK