Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken Build Process #110

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix Broken Build Process #110

wants to merge 6 commits into from

Conversation

manuth
Copy link

@manuth manuth commented Mar 24, 2022

Currently, there are a few problems preventing this extension from being compiled.
Thus, this PR will change following aspects of the code:

  • Remove obsolete @types/socket.io as socket.io has its own type-declarations built-in
  • Upgrade typescript to 4.6 as socket.io seems to use labeled tuples which requires typescript to be at least 4.0
  • Replace .svg picture with .png as vsce doesn't allow .svg images inside the README.md file
  • Add DOM to tsconfig.json as engine.io-parser uses the Blob-type which is exclusive to the DOM library

@manuth manuth mentioned this pull request Mar 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manuth