Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the display of the tutorial page and add adjust_legend argument #707

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

Starlitnightly
Copy link

@Starlitnightly Starlitnightly commented Oct 17, 2024

The new tutorial could be found in https://dynamo-release-test.readthedocs.io/en/latest/index.html.

  1. It is important to note that the notebook for this tutorial depends on dynamo-tutorials, but there are some issues related to submodules. These should be carefully checked before merging.
  2. Version 1.4.2 has not yet been officially released, so I have defined the version number as 1.4.2rc1. I am not sure if this version is allowed to be released. Since the adjust_legend parameter depends on version 1.4.2, I have added the adjust_legend parameter to most updated tutorials to optimize the plotting effects.

@Starlitnightly
Copy link
Author

#706

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.92079% with 1759 lines in your changes missing coverage. Please review.

Project coverage is 37.67%. Comparing base (94bb9d1) to head (52efe86).

Files with missing lines Patch % Lines
dynamo/multivelo/old_MultiVelocity.py 8.05% 628 Missing ⚠️
dynamo/multivelo/MultiPreprocessor.py 14.93% 245 Missing ⚠️
dynamo/multivelo/pyWNN.py 9.04% 171 Missing ⚠️
dynamo/multivelo/ATACseqTools.py 10.98% 154 Missing ⚠️
dynamo/multivelo/MultiIO.py 12.42% 141 Missing ⚠️
dynamo/multivelo/old_MultiomicVectorField.py 17.21% 125 Missing ⚠️
dynamo/multivelo/ChromatinVelocity.py 9.55% 123 Missing ⚠️
dynamo/multivelo/MultiQC.py 23.80% 48 Missing ⚠️
dynamo/multivelo/sparse_matrix_utils.py 0.00% 45 Missing ⚠️
dynamo/multivelo/MultiVelo.py 21.62% 29 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   43.59%   37.67%   -5.93%     
==========================================
  Files         161      177      +16     
  Lines       28734    33946    +5212     
==========================================
+ Hits        12527    12788     +261     
- Misses      16207    21158    +4951     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiaojieqiu Xiaojieqiu requested a review from Sichao25 October 29, 2024 19:32
@Sichao25
Copy link
Collaborator

Are we also using this repo for ReadTheDocs instead of dynamo_readthedocs in the future?

@Xiaojieqiu
Copy link
Collaborator

Xiaojieqiu commented Oct 31, 2024

@Sichao25 we will need to overwrite the old dynamo_readthedocs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants