Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code quality check #607

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Nov 3, 2023

Check code quality with black and isort in workflow instead of flake8.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.59%. Comparing base (94bb9d1) to head (3884b1d).

Files with missing lines Patch % Lines
dynamo/external/hodge.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         161      161           
  Lines       28734    28735    +1     
=======================================
+ Hits        12527    12528    +1     
  Misses      16207    16207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants