Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization bug #601

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AlexanderCaichen
Copy link
Contributor

Add new input variable for Preprocessor object to skip normalization in case data-to-be-preprocessed is already normalized.

@Xiaojieqiu
Copy link
Collaborator

Thanks @AlexanderCaichen for the great work. It will be nice to allow the preprocessing algorithm knows whether the data is already normalized or not automatically. Is this not something different?

@AlexanderCaichen
Copy link
Contributor Author

AlexanderCaichen commented Nov 7, 2023

@Xiaojieqiu Because there are so many ways of normalizing data I thought it will be difficult to have a single function automatically detect whether some data is normalized.

While I can add a check somewhere to see if some data is normalized by Dynamo, it is possible that the data to be preprocessed is already pre-normalized outside of Dynamo.

My changes simply gives the User the option of canceling normalization in Dynamo in case they pre-normalized it instead of automatically detecting normalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants