Code Coverage #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there's a way to reduce the amount of chnages to the |
|
The only way to reduce the amount of dependencies that are pulled in is to add an override in Also, can we have the coverage results output somewhere other than in the src folder? |
|
The coverage should be output to the |
DNoved1
force-pushed
the
devon-code-coverage
branch
from
f76e51e to
1188156
Compare
added 2 commits
April 26, 2016 02:53
A few problems need to still be solved:
* Automatically writing the coverage data to a file. As mentioned in
one of the comments in test/index.html, this can be done with the
browser file api which is only supported by chrome at the moment, or
perhaps by using web sockets to send the data back to the server
which can then write the file to disk.
* Source maps - currently istanbul's code coverage is based on the
transpiled typescript, and so does not accurately reflect the
original code. It's possible to connect the two mentally, but
difficult. The remap-istanbul project may be of use here.
* The method of injecting istanbul into the SystemJS module loader is
a bit of a hack; we can probably make it a cleaner hack by writing a
SystemJS plugin which we use specifically for loading our files
during testing.
Aka the previous coverage reports over the transpiled js (from ts) now have sourcemaps applied to them so that the coverage reports are now over ts. Also made coverage reports be automatically written as the tests are run.
DNoved1
force-pushed
the
devon-code-coverage
branch
from
1188156 to
d61d48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Istanbul and Remap-Istanbul.
The basic code flow is:
istanbul.socket.io(included withbrowser-sync).remap-istanbulto apply the sourcemaps to the transpiled js in order to get coverage data for the original typescript.coverage/index.htmlusingistanbul.