Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRBrowser touch fix #579

Merged
merged 2 commits into from
Sep 1, 2023
Merged

XRBrowser touch fix #579

merged 2 commits into from
Sep 1, 2023

Conversation

hi-liang
Copy link
Member

@hi-liang hi-liang commented Aug 31, 2023 •
edited
Loading

TODO:

  • resolve transient hit-test issues with XRBrowser (if possible?)
  • determine guarantees of xr select intersections in a-cursor successfully disabling ar-hit-test
    before it can execute the hit test, as both events firing have been regularly observed

@hi-liang
refactor: mouse/xr raycaster to webxr-device-manager
e922aa8 
For the switch between the camera-child cursor w/ mouse rayOrigin
and the scene level xrselect cursor, this is more sensibly located
in the webxr-device manager instead of the ar-hit-test-listener
@hi-liang
fix: working window listener for XRBrowser touch
fef91cf 
- xrSession event binding that comes with a-cursor does not work for XRBrowser
- canvas event listeners no longer work either, as scene from the initial
  center-screen workaround, window/document listeners _do_ work
@hi-liang
Copy link
Member Author

hi-liang commented Sep 1, 2023

Deferring those TODOs to #580

@hi-liang hi-liang merged commit 0716135 into master Sep 1, 2023
@hi-liang hi-liang deleted the xrtouch branch September 1, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hi-liang