-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server.available() according to reference. with example #323
Open
JAndrassy
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
JAndrassy:server_available_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jan 9, 2022
Memory usage change @ 7d8c54e
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference for WiFi101 server.available() has
which is same as for the Ethernet library and WiFiNINA library, and many other libraries implementing the Arduino networking API introduced by the Ethernet library.
But server.available() in WiFi101 library now returns a just connected client even if it doesn't have data available yet. (This is an interesting workaround for missing accept() function, but it is causing problems sometimes even with the examples of the WiFi101 library.)
This PR fixes available() and my other PR adds accept(), but the change of available() should be considered as breaking change, because sketch which expected server.available() to return new connected clients even without data, will break.
and the PR contains my example PagerServer (already accepted in Ethernet library) which concentrates on how server.available() and print-to-all-clients works.