checkservices: honor -R flag #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the -R flag were parsed it were not honored and there was no way to skip being asked for restart with the -R flag. Useful for putting checkservices in an alpm hook.
Foxboron
approved these changes
May 20, 2023
jelly
requested changes
May 26, 2023
| @@ -298,7 +298,7 @@ main() { | |||
| echo "Found: ${#broken_services[@]}" | |||
| if (( ${#broken_services[@]} )); then | |||
| display_restart "${broken_services[@]}" | |||
| if confirm 'Execute?'; then | |||
| if (( $RESTART )) && confirm 'Execute?'; then | |||
There was a problem hiding this comment.
Testing this out, I think this condition should be moved up as now the output is kinda confusing:
[jelle@t14s][~/projects/contrib]%sudo ./admin/checkservices -R -P
:: Reload systemd
:: Services with broken maps files
Error:: Unable to parse pid file for systemd-udevd.service.
Found: 6
-------8<-------------------------------8<---------
systemctl restart 'atop.service'
systemctl restart 'cups.service'
systemctl restart 'systemd-journald.service'
systemctl restart 'systemd-logind.service'
systemctl restart 'systemd-machined.service'
systemctl restart 'systemd-timesyncd.service'
-------8<-------------------------------8<---------
:: Services missing on the system bus
Would be better to merge the $RESTART with the if above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the -R flag were parsed it were not honored and there was no way to skip being asked for restart with the -R flag. Useful for putting checkservices in an alpm hook.