Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set dynamic type for docs items #201

Merged
merged 1 commit into from
Sep 17, 2023
Merged

set dynamic type for docs items #201

merged 1 commit into from
Sep 17, 2023

Conversation

orimdominic
Copy link
Contributor

Sequel to this comment in #162

This PR aims to type the items in the docs field returned from calling the paginate function.
It uses TypeScript function overloads to achieve this

@orimdominic orimdominic changed the title accept type param for docs field in paginate set type for docs items Sep 15, 2023
@orimdominic orimdominic changed the title set type for docs items set dynamic type for docs items Sep 15, 2023
aravindnc
aravindnc approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@aravindnc aravindnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aravindnc aravindnc merged commit 8d4c507 into aravindnc:master Sep 17, 2023
1 check passed
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 4, 2024
Open
@angeloreale angeloreale mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindnc aravindnc aravindnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orimdominic @aravindnc