-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stabilize t in app directory #1206
Conversation
@aralroca mind taking a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a851d30
to
3e96897
Compare
This PR does not change the behavior of the hook in the Pages router, so no regression is present there. I tested out shared layouts in the App router via the demo.mov |
@aralroca could you please have another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
@jessemartin I have updated the canary branch because in master there were changes that were not in the canary, and just failed the test " |
@aralroca looks like the problem was a merge conflict (the upstream logic had moved to |
Thanks a lot @jessemartin 😊 |
@all-contributors please add @jessemartin for code |
I've put up a pull request to add @jessemartin! 🎉 |
@aralroca can you create a new canary release that ships this? |
@kristian240 I've pre-released 3.0.0-canary.4 now with the latest changes in the canary branch. Give feedback if everything is ok. I have to make revision and re-take the route-map for 3.0.0. I feel that in the last months there has been a lot of focus on Brisa framework, now it's time to work for 3.0.0 version of next-translate and give good support on Next.js 15. |
This was quick, thanks a lot. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
stabilized t in app directory
Which issue (if any) does this pull request address?
#1205
Is there anything you'd like reviewers to focus on?