fix: ignore empty lang value #1162

[timotew]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x ] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Ignore empty translations for generated pages.

Which issue (if any) does this pull request address?

#1162

Is there anything you'd like reviewers to focus on?

[nightire]

The current fix is not enough because I18nProvider also suffered from this. Below is what I saw with my local building:

tx-support:build: RangeError: Incorrect locale information provided
tx-support:build:     at new PluralRules (<anonymous>)
tx-support:build:     at I18nProvider (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next-translate/lib/cjs/I18nProvider.js:57:23)
tx-support:build:     at Wc (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:68:44)
tx-support:build:     at Zc (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:253)
tx-support:build:     at Z (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)
tx-support:build:     at Zc (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:481)
tx-support:build:     at Z (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)
tx-support:build:     at Zc (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:481)
tx-support:build:     at Z (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)
tx-support:build:     at $c (/Users/nightire/Code/github.com/choice-form/tx-hub/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:78:98)

So I made the exact change here, and it finally works:

next-translate/src/I18nProvider.tsx

Line 27 in a759d71

const ignoreLang = localesToIgnore.includes(lang)

[aralroca]

Thanks @timotew

[aralroca]

@esupper thanks, I'm going to do this change in another PR

[timotew]

Thanks @aralroca and @esupper . Unfortunately, I have not had the time to reproduce the issues that @nightire mentioned and that's why I have not added it to this change.

[aralroca]

No worry. Thank you @timotew so much for the contribution!! @all-contributors please add @timotew for code

[allcontributors]

@aralroca

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @timotew! 🎉