Fix error when clean up scripts run #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: --- * The clean up scripts were relying on the shells `rm -rf` command which was causing to fail when the files matching the pattern were missing. I've replaced this with the `del-cli` node package that ignores those missing files.
aralroca
approved these changes
Aug 14, 2023
|
@all-contributors please add @crs1138 for maintenance |
|
I've put up a pull request to add @crs1138! 🎉 |
crs1138
added a commit
to crs1138/next-translate
that referenced
this pull request
Aug 16, 2023
…-locale-from * 'master' of github.com:aralroca/next-translate: Fix error when clean up scripts run (aralroca#1132) docs: add crs1138 as a contributor for maintenance (aralroca#1134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
The clean up scripts were relying on the shells
rm -rfcommand which was causing to fail when the files matching the pattern were missing. I've replaced this with thedel-clinode package that ignores those missing files.Which issue (if any) does this pull request address?
This is addressing #891
Is there anything you'd like reviewers to focus on?