refactor: add generic Set implementation #8149
Draft
+898
−244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set[T]
interface and its implementation usingmap[T]struct{}
under the hoodNew()
,Clone()
, and set operations (Union, Intersection, Difference)set
package instead of rawmap[T]struct{}
Why
map[T]struct{}
as sets in our codebase, which could benefit from a more readable and feature-rich implementationImplementation Details
unsafeSet
) is not thread-safe by design, as that matches our current usage patternsAdditional Information
map[T]struct{}
Checklist