Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): add escaping quotes in misconfig Title for asff template #5351

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(report): add escaping quotes in misconfig Title for asff template #5351

merged 1 commit into from
Oct 11, 2023

Conversation

DmitriyLewen
Copy link
Contributor

Description

Misconfiguration titles may contains quotes.
e.g.:

  • Image user should not be 'root').
  • ... It is recommended that VPC Flow Logs be enabled for packet "Rejects" for VPCs

We currently only escaping quotes only for Description.
We also need to escape quotes for Title.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 9, 2023 06:55
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner October 9, 2023 06:55
@simar7 simar7 self-requested a review October 10, 2023 21:02
@knqyf263 knqyf263 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into aquasecurity:main with commit 20ab703 Oct 11, 2023
11 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/unescaped-quotes-asff-misconf-title branch October 11, 2023 08:32
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unescaped quotes for misconf title in asff format
3 participants
@DmitriyLewen @simar7 @knqyf263