[fix] Use environment variable for GitHub API #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GITHUB_API_URL for the request to the dependency snapshot endpoint so requests work in GitHub Enterprise Server.
|
|
|
Thanks for the PR! Rather than passing this in as-is, can we define a custom variable that can be overwritten by the user if needed but has a default value of what we have today? That would ensure we don't break backwards compatibility with the existing users in case there's any issue with this change. WDYT? |
|
It would also be helpful if you can test this change and share the results with us. |
Add an option to override the GitHub API URL to use - defaults to `$GITHUB_API_URL`.
|
Added the ability to override the value. I'm afraid I can't test this in our GitHub Enterprise instance as we're currently only trialling GitHub Advanced Security, and our license has now expired. |
|
@simar7 Anything more you need me to do here? |
|
Anyone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GITHUB_API_URL(docs) for the request to the dependency snapshot endpoint so requests work in GitHub Enterprise Server where the API isn't found atapi.github.com.Resolves #312.