Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'hide-progress' input working again #323

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Make 'hide-progress' input working again #323

merged 2 commits into from
Mar 29, 2024

Conversation

uridium
Copy link
Contributor

@uridium uridium commented Mar 27, 2024

I tried to use this example, but Trivy is returning an error, when defining hide-progress: false or hide-progress: true input.
image

This PR allows Trivy to use the correct --quiet flag, instead of non existing --no-progress.
image

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left a comment.

action.yaml Outdated
required: false
default: 'true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be turned on by default as users expect to the see the output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing this up, as there were discrepancies between the doc and the code.
Updated.

@uridium uridium requested a review from simar7 March 28, 2024 08:07
@uridium uridium changed the title Make hide-progress input working again Make 'hide-progress' input working again Mar 28, 2024
@simar7 simar7 merged commit f72b7e8 into aquasecurity:master Mar 29, 2024
1 of 2 checks passed
juanjjaramillo referenced this pull request in newrelic/helm-charts Jul 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[aquasecurity/trivy-action](https://togithub.com/aquasecurity/trivy-action)
| action | minor | `0.19.0` -> `0.24.0` |

---

### Release Notes

<details>
<summary>aquasecurity/trivy-action (aquasecurity/trivy-action)</summary>

###
[`v0.24.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.24.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.23.0...0.24.0)

#### What's Changed

- Upgrade trivy to v0.53.0 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/369](https://togithub.com/aquasecurity/trivy-action/pull/369)

**Full Changelog**:
aquasecurity/trivy-action@0.23.0...0.24.0

###
[`v0.23.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.23.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.22.0...0.23.0)

#### What's Changed

- Upgrade trivy to v0.52.2 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/367](https://togithub.com/aquasecurity/trivy-action/pull/367)

**Full Changelog**:
aquasecurity/trivy-action@0.22.0...0.23.0

###
[`v0.22.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.22.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.21.0...0.22.0)

#### What's Changed

- chore(docs): Reference the use of a pinned version by
[@&#8203;simar7](https://togithub.com/simar7) in
[https://github.com/aquasecurity/trivy-action/pull/356](https://togithub.com/aquasecurity/trivy-action/pull/356)
- Upgrade trivy to v0.52.0 by
[@&#8203;Keralin](https://togithub.com/Keralin) in
[https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364)

#### New Contributors

- [@&#8203;Keralin](https://togithub.com/Keralin) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364)

**Full Changelog**:
aquasecurity/trivy-action@0.21.0...0.22.0

###
[`v0.21.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.21.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.20.0...0.21.0)

#### What's Changed

- bump trivy version to v0.51.2 by
[@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) in
[https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360)

#### New Contributors

- [@&#8203;Dr-DevOps](https://togithub.com/Dr-DevOps) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360)

**Full Changelog**:
aquasecurity/trivy-action@0.20.0...0.21.0

###
[`v0.20.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.20.0)

[Compare
Source](https://togithub.com/aquasecurity/trivy-action/compare/0.19.0...0.20.0)

##### What's Changed

- Make 'hide-progress' input working again by
[@&#8203;uridium](https://togithub.com/uridium) in
[https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323)
- feat(image): add `--docker-host` option for GH Action users by
[@&#8203;calinmarina](https://togithub.com/calinmarina) in
[https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267)
- Browse Trivy reports without GitHub Advanced Security license by
[@&#8203;uridium](https://togithub.com/uridium) in
[https://github.com/aquasecurity/trivy-action/pull/328](https://togithub.com/aquasecurity/trivy-action/pull/328)
- Fix docker host bug by
[@&#8203;admiralAwkbar](https://togithub.com/admiralAwkbar) in
[https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329)
- Bump trivy version to v0.50.2 by
[@&#8203;pdefreitas](https://togithub.com/pdefreitas) in
[https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341)
- update tests by [@&#8203;nikpivkin](https://togithub.com/nikpivkin) in
[https://github.com/aquasecurity/trivy-action/pull/334](https://togithub.com/aquasecurity/trivy-action/pull/334)
- bump trivy version to v0.51.1 by
[@&#8203;simar7](https://togithub.com/simar7) in
[https://github.com/aquasecurity/trivy-action/pull/353](https://togithub.com/aquasecurity/trivy-action/pull/353)

##### New Contributors

- [@&#8203;uridium](https://togithub.com/uridium) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323)
- [@&#8203;calinmarina](https://togithub.com/calinmarina) made their
first contribution in
[https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267)
- [@&#8203;admiralAwkbar](https://togithub.com/admiralAwkbar) made their
first contribution in
[https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329)
- [@&#8203;pdefreitas](https://togithub.com/pdefreitas) made their first
contribution in
[https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341)

**Full Changelog**:
aquasecurity/trivy-action@0.19.0...0.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy40MjUuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants