chore(ci): add codecov #4064
Closed
chore(ci): add codecov #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
reviewed
May 21, 2024
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/[email protected] | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Changes are already tested on fork repo https://github.com/rahul2393/tracee/pull/6
.github/workflows/pr.yaml
Outdated
| @@ -224,6 +224,11 @@ jobs: | |||
| - name: Run Unit Tests | |||
| run: | | |||
| make test-unit | |||
| - name: Upload coverage reports to Codecov | |||
| uses: codecov/[email protected] | |||
There was a problem hiding this comment.
Would you mind using this pattern?
...@hash # vX.X.X
tracee/.github/workflows/pr.yaml
Line 128 in 00598de
geyslan
reviewed
May 22, 2024
| @@ -224,6 +224,11 @@ jobs: | |||
| - name: Run Unit Tests | |||
| run: | | |||
| make test-unit | |||
| - name: Upload coverage reports to Codecov | |||
| uses: codecov/codecov-action@e0b68c6749509c5f83f984dd99a76a1c1a231044 #v4.0.1 | |||
There was a problem hiding this comment.
Nice!
The latest version is v4.4.1. Is there a reason for not using it? If so, please insert a comment explaining it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fixes: #152
2. Explain how to test it
3. Other comments