Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to update amazon 2 in cron workflow #104

Closed
wants to merge 2 commits into from

Conversation

brycekahle
Copy link
Collaborator

Adds a job that uses the amazonlinux:2 container to automatically update Amazon kernels. I figured out and added support to search both architectures from a single arch machine. I basically add the cross-arch repo on container setup and then search for packages using repoquery which supports --archlist.

Also fixes btfhub run commands to only use sudo when it is present.

This also makes a couple changes to how things are structured:

  • removes archive and custom-archive directories from repo
  • clones btfhub directly into the workspace directory
  • clones btfhub-archive directly into the archive directory. This prevents the need for rsync-ing files around.
  • adds sparse checkout of btfhub-archive to improve clone speeds.

@brycekahle brycekahle force-pushed the bryce.kahle/amazon-cron branch from 0a0c4df to 1757335 Compare January 4, 2024 22:00
@rafaeldtinoco rafaeldtinoco removed their request for review January 5, 2024 16:34
@brycekahle brycekahle force-pushed the bryce.kahle/amazon-cron branch from 1757335 to e2582da Compare January 9, 2024 23:38
@geyslan
Copy link
Member

geyslan commented Apr 16, 2024

@brycekahle sorry for the delay. Is this still relevant? Should I go on reviewing it?

@brycekahle
Copy link
Collaborator Author

@geyslan We are maintaining our own fork now, since we needed to add support for kernel modules. Feel free to do what you wish with this PR.

@geyslan
Copy link
Member

geyslan commented Apr 26, 2024

@brycekahle I'm addressing a few other issues, but I'll take a closer look at this PR soon. In the meantime, can you explain why you created a new job just for Amazon?


I figured out and added support to search both architectures from a single arch machine. I basically add the cross-arch repo on container setup and then search for packages using repoquery which supports --archlist.

I meant, wouldn't it be possible to infer this by accessing the repo files directly?

@brycekahle
Copy link
Collaborator Author

I was unable to access the repos directly outside of Amazon Linux.

@geyslan
Copy link
Member

geyslan commented Jun 5, 2024

@brycekahle I've got a time to go over this. I'm closing it in favour of #118.

@geyslan geyslan closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants