Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfocators in 8idd and e #66

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Transfocators in 8idd and e #66

merged 3 commits into from
Aug 30, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian self-assigned this Aug 28, 2024
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should initialize both devices in the same file since they use the same class? On one hand less code, on another we encounter the initialization problem Victoria was discussing yesterday. Thoughts?

@prjemian
Copy link
Contributor Author

prjemian commented Aug 29, 2024

Do you think we should initialize both devices in the same file since they use the same class? On one hand less code, on another we encounter the initialization problem Victoria was discussing yesterday. Thoughts?

Just like yesterday's discussion. As @sureshnaps stated:

8IDI should not load all the 8IDE devices

If they are in one file, both will be connected.

@prjemian
Copy link
Contributor Author

I thought about a reuseable class which could be used by both. But that would make the code larger and look much more complicated. Instead, chose to write using the same class name but different motor numbers internally.

These classes are singletons. Could rename them with a preceding _ to hint they are local definitions of the class and not intended for re-use.

@MDecarabas
Copy link
Collaborator

I thought about a reuseable class which could be used by both. But that would make the code larger and look much more complicated. Instead, chose to write using the same class name but different motor numbers internally.

These classes are singletons. Could rename them with a preceding _ to hint they are local definitions of the class and not intended for re-use.

No need, let's go ahead like this for now and we can chat at a later time about a more elegant permanent solution

@prjemian prjemian merged commit 7ccd08c into main Aug 30, 2024
1 check passed
@prjemian prjemian deleted the 61-Transfocator-8IDD branch August 30, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfocator in 8-ID-D & 8-ID-E
2 participants