-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfocators in 8idd and e #66
Conversation
prjemian
commented
Aug 28, 2024
- close Transfocator in 8-ID-D & 8-ID-E #61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should initialize both devices in the same file since they use the same class? On one hand less code, on another we encounter the initialization problem Victoria was discussing yesterday. Thoughts?
Just like yesterday's discussion. As @sureshnaps stated:
If they are in one file, both will be connected. |
I thought about a reuseable class which could be used by both. But that would make the code larger and look much more complicated. Instead, chose to write using the same class name but different motor numbers internally. These classes are singletons. Could rename them with a preceding |
No need, let's go ahead like this for now and we can chat at a later time about a more elegant permanent solution |