Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to select table rows #34753

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: Unable to select table rows #34753

merged 2 commits into from
Jul 8, 2024
+8 −2

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented Jul 5, 2024 •
edited by coderabbitai bot
Loading

Fixes #34616

/ok-to-test tags="@tag.Anvil"

Summary by CodeRabbit

  • Bug Fixes
    • Improved row selection in the table widget to ensure consistent behavior when clicking and selecting rows.

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9807025998
Commit: 0886840
Cypress dashboard.
Tags: @tag.Anvil

Fri, 05 Jul 2024 10:57:35 UTC

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 5, 2024 •
edited
Loading

Walkthrough

The recent modifications focus on enhancing the Row component within the WDSTableWidget. The onClickRow function now accepts a React.MouseEvent parameter, ensuring proper event handling. Furthermore, the onChange event handler for the Checkbox has been revised to include row selection functionality. These updates aim to address issues with row selection and event firing within the table widget.

Changes

File Path Change Summary
.../WDSTableWidget/component/TableBody/Row.tsx Updated onClickRow to accept React.MouseEvent parameter and modified onChange of Checkbox to handle row selection.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Unable to select table rows (#34616) ✅
onRowSelect event does not fire when clicking rows (#34616) ✅

Poem

In fields of code where tables grow,
Rows select with a gentle flow.
Events now fire, their purpose clear,
The table's song all can hear.
A bunny’s cheer for the updates done,
Every row now joins the fun! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users WDS team labels Jul 5, 2024
@jsartisan
Copy link
Contributor Author

/ok-to-test tags="@tag.Anvil"

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Whoops! Looks like you're using an outdated method of running the Cypress suite.
Please check this doc to learn how to correct this!

@jsartisan
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9806774958.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34753.
recreate: .

coderabbitai[bot]
coderabbitai bot reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3771508 and 0886840.

Files selected for processing (1)
  • app/client/src/widgets/wds/WDSTableWidget/component/TableBody/Row.tsx (3 hunks)
Additional comments not posted (2)
app/client/src/widgets/wds/WDSTableWidget/component/TableBody/Row.tsx (2)

47-50: LGTM! The changes to onClickRow function are appropriate.

The function now correctly toggles row selection, calls selectTableRow, and stops event propagation.

75-78: LGTM! The changes to the onChange event handler for the Checkbox component are appropriate.

The event handler now correctly toggles row selection and calls selectTableRow.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Deploy-Preview-URL: https://ce-34753.dp.appsmith.com

@jsartisan jsartisan requested a review from KelvinOm July 5, 2024 10:36
@jsartisan jsartisan added the ok-to-test Required label for CI label Jul 5, 2024
@jsartisan jsartisan requested a review from riodeuno July 8, 2024 08:01
coderabbitai[bot]
coderabbitai bot reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0886840 and 9cff10d.

Files selected for processing (1)
  • app/client/src/widgets/wds/WDSTableWidget/component/TableBody/Row.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/widgets/wds/WDSTableWidget/component/TableBody/Row.tsx

@KelvinOm KelvinOm merged commit b610ebd into release Jul 8, 2024
15 checks passed
@KelvinOm KelvinOm deleted the fix/table-widget-row-select branch July 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@znamenskii-ilia znamenskii-ilia znamenskii-ilia approved these changes

@KelvinOm KelvinOm KelvinOm approved these changes

@riodeuno riodeuno Awaiting requested review from riodeuno

Assignees
No one assigned
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users ok-to-test Required label for CI WDS team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to select table rows
3 participants
@jsartisan @znamenskii-ilia @KelvinOm