-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Extend character limit for API, query, and datasource names #34710
base: release
Are you sure you want to change the base?
fix: Extend character limit for API, query, and datasource names #34710
Conversation
WalkthroughThe changes improve the user experience and validation in various parts of the application. Specifically, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant NameValidator
participant TextInputHandler
User->>UI: Enter name in ActionNameEditor
UI->>TextInputHandler: Adjust input width, set maxLength
TextInputHandler->>NameValidator: Validate name
NameValidator->>TextInputHandler: Return validation result
TextInputHandler-->>User: Show feedback (valid/invalid)
User->>UI: Enter name in FormTitle
UI->>TextInputHandler: Apply removeSpecialChars, set maxLength
TextInputHandler->>NameValidator: Validate name
NameValidator->>TextInputHandler: Return validation result
TextInputHandler-->>User: Show feedback (valid/invalid)
Poem
ヽ(•‿•)ノ Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- app/client/src/components/editorComponents/ActionNameEditor.tsx (3 hunks)
- app/client/src/components/utils/NameEditorComponent.tsx (3 hunks)
- app/client/src/pages/Editor/DataSourceEditor/FormTitle.tsx (2 hunks)
- app/client/src/utils/helpers.tsx (2 hunks)
Files skipped from review due to trivial changes (2)
- app/client/src/components/editorComponents/ActionNameEditor.tsx
- app/client/src/utils/helpers.tsx
Additional comments not posted (4)
app/client/src/components/utils/NameEditorComponent.tsx (2)
114-116
: LGTM! Simplified logic is correct.The refactored logic in
isInvalidNameForEntity
is more concise and maintains the same functionality.
127-127
: LGTM! Dependency array update is correct.Including
suffixErrorMessage
in the dependency array ensures thehandleNameChange
function is correctly updated whensuffixErrorMessage
changes.app/client/src/pages/Editor/DataSourceEditor/FormTitle.tsx (2)
146-146
: LGTM!maxLength
update is correct.Setting the
maxLength
to 256 characters aligns with the PR objective to extend the character limit for names.
152-153
: LGTM!valueTransform
update is correct.Using
removeSpecialChars
asvalueTransform
ensures special characters are removed from the input value, enhancing input validation.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Improvements