-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commit icon of github on airgapped, the app crashes. #33812 #34673
base: release
Are you sure you want to change the base?
fix: commit icon of github on airgapped, the app crashes. #33812 #34673
Conversation
Page crashes happened because of null pointer exception from front-end code, fixed that one.
WalkthroughThe Changes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/client/src/pages/Editor/gitSync/components/ReconnectSSHError.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/pages/Editor/gitSync/components/ReconnectSSHError.tsx
Screenshot after Solving the app crash.
![image](https://private-user-images.githubusercontent.com/165656044/345365793-5c6f3c9a-4fc6-4404-aa99-2a87293b2963.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MzE5NDUsIm5iZiI6MTcyMDUzMTY0NSwicGF0aCI6Ii8xNjU2NTYwNDQvMzQ1MzY1NzkzLTVjNmYzYzlhLTRmYzYtNDQwNC1hYTk5LTJhODcyOTNiMjk2My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwOVQxMzI3MjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGUwMDU4YWQzM2ExZjFmOTUyZjQxNDJmNTg3MTViNGEzMmNmYTRlZjFhYWFmMzBjY2FiNTdkZjI2Yzc5MDUzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.jBejqD1GSOkHVy6RKKe2S9o6C-rTLclpKETRJ1TN7hc)
Bug Fixes:
Page crashes happened because of null pointer exception from front-end code, fixed that one.
Fixes : #33812 .
Summary by CodeRabbit
ReconnectSSHError
component to prevent crashes due to undefined nested properties using optional chaining.