chore: zone and section snapshots #34639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe new file Changes
Sequence Diagram(s)No sequence diagrams are necessary as the changes are related to testing functionalities rather than altering or adding new features or control flows. Possibly related issues
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
app/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetCanvas.snap.pngis excluded by!**/*.pngapp/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetCanvasDark.snap.pngis excluded by!**/*.pngapp/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetDeployipad-2.snap.pngis excluded by!**/*.pngapp/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetDeployiphone-6.snap.pngis excluded by!**/*.pngapp/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetDeploymacbook-13.snap.pngis excluded by!**/*.pngapp/client/cypress/snapshots/AnvilZoneSectionWidgetSnapshot_spec.ts/anvilZoneSectionWidgetPreview.snap.pngis excluded by!**/*.png
Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts (1 hunks)
- app/client/cypress/fixtures/anvilZoneSectionWidget.json (1 hunks)
Files not summarized due to errors (1)
- app/client/cypress/fixtures/anvilZoneSectionWidget.json: Error: Message exceeds token limit
Files skipped from review due to trivial changes (1)
- app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts
Additional comments not posted (4)
app/client/cypress/fixtures/anvilZoneSectionWidget.json (4)
1221-1236: Ensure widget properties are correctly defined.The properties for the "Section5" widget seem consistent and complete. However, verify that the
widgetIdand other unique identifiers are correct and not duplicated elsewhere.
3-12: Ensure widget properties are correctly defined.The properties for the "MainContainer" widget seem consistent and complete. However, verify that the
widgetIdand other unique identifiers are correct and not duplicated elsewhere.Verification successful
Widget properties are correctly defined.
The
widgetIdand other unique identifiers within theapp/client/cypress/fixtures/anvilZoneSectionWidget.jsonfile are unique and correctly defined.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique across the JSON file. # Test: Check for duplicate widgetIds. Expect: No duplicates. rg --type json '"widgetId":' | sort | uniq -dLength of output: 109161
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique within the file `anvilZoneSectionWidget.json`. # Test: Check for duplicate widgetIds within `anvilZoneSectionWidget.json`. Expect: No duplicates. rg --type json '"widgetId":' app/client/cypress/fixtures/anvilZoneSectionWidget.json | sort | uniq -dLength of output: 103
184-199: Ensure widget properties are correctly defined.The properties for the "Section1" widget seem consistent and complete. However, verify that the
widgetIdand other unique identifiers are correct and not duplicated elsewhere.Verification successful
Ensure widget properties are correctly defined.
The properties for the "Section1" widget seem consistent and complete. However, verify that the
widgetIdand other unique identifiers are correct and not duplicated within theapp/client/cypress/fixtures/anvilZoneSectionWidget.jsonfile.
Verified: Widget properties are correctly defined and unique.
The
widgetIdand other unique identifiers in theapp/client/cypress/fixtures/anvilZoneSectionWidget.jsonfile are correctly defined and do not have duplicates.
- No duplicate
widgetIdvalues found in the file.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique across the JSON file. # Test: Check for duplicate widgetIds. Expect: No duplicates. rg --type json '"widgetId":' | sort | uniq -dLength of output: 109161
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique within the anvilZoneSectionWidget.json file. # Test: Check for duplicate widgetIds within the specific JSON file. Expect: No duplicates. rg --type json '"widgetId":' app/client/cypress/fixtures/anvilZoneSectionWidget.json | sort | uniq -dLength of output: 103
1081-1096: Ensure widget properties are correctly defined.The properties for the "Section4" widget seem consistent and complete. However, verify that the
widgetIdand other unique identifiers are correct and not duplicated elsewhere.Verification successful
Ensure
widgetIdvalues are unique and valid inanvilZoneSectionWidget.json.The script output indicates that there are multiple instances of non-unique and invalid
widgetIdvalues across several JSON files. To specifically verify thewidgetIdvalues inapp/client/cypress/fixtures/anvilZoneSectionWidget.json, please run the following script:
Widget properties are correctly defined and
widgetIdvalues are unique and valid.The
widgetIdvalues inapp/client/cypress/fixtures/anvilZoneSectionWidget.jsonare unique and valid, with no duplicates, empty strings, or boolean values found.
- No duplicates found for
widgetId.- No invalid values found for
widgetId.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique across the JSON file. # Test: Check for duplicate widgetIds. Expect: No duplicates. rg --type json '"widgetId":' | sort | uniq -dLength of output: 109161
Script:
#!/bin/bash # Description: Verify that the widgetId and other unique identifiers are unique and valid in `anvilZoneSectionWidget.json`. # Test: Check for duplicate widgetIds and invalid values in `anvilZoneSectionWidget.json`. Expect: No duplicates, no empty strings, and no boolean values. rg --type json '"widgetId":' app/client/cypress/fixtures/anvilZoneSectionWidget.json | sort | uniq -d rg --type json '"widgetId": ""' app/client/cypress/fixtures/anvilZoneSectionWidget.json rg --type json '"widgetId": true' app/client/cypress/fixtures/anvilZoneSectionWidget.jsonLength of output: 285
Comment on lines
+1443
to
+1458
| "needsErrorInfo": false, | ||
| "boxShadow": "NONE", | ||
| "mobileBottomRow": 10, | ||
| "widgetName": "Section5Copy", | ||
| "isCanvas": true, | ||
| "displayName": "Section", | ||
| "searchTags": [ | ||
| "div", | ||
| "parent", | ||
| "group" | ||
| ], | ||
| "topRow": 0, | ||
| "bottomRow": 10, | ||
| "parentRowSpace": 10, | ||
| "type": "SECTION_WIDGET", | ||
| "hideCard": true, |
There was a problem hiding this comment.
Tip
Codebase Verification
Duplicate and Invalid widgetId Values Detected
The verification process has identified multiple instances of duplicate and invalid widgetId values across various JSON files. This includes empty strings and true values, which are not valid identifiers.
- Duplicate
widgetIdvalues: Ensure that eachwidgetIdis unique across all JSON files. - Invalid
widgetIdvalues: Replace empty strings andtruevalues with valid, unique identifiers.
Please address these issues to maintain the integrity of the widget configuration.
Analysis chain
Ensure widget properties are correctly defined.
The properties for the "Section6" widget seem consistent and complete. However, verify that the widgetId and other unique identifiers are correct and not duplicated elsewhere.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the widgetId and other unique identifiers are unique across the JSON file.
# Test: Check for duplicate widgetIds. Expect: No duplicates.
rg --type json '"widgetId":' | sort | uniq -d
Length of output: 109161
Comment on lines
+559
to
+574
| "needsErrorInfo": false, | ||
| "boxShadow": "NONE", | ||
| "mobileBottomRow": 10, | ||
| "widgetName": "Section2", | ||
| "isCanvas": true, | ||
| "displayName": "Section", | ||
| "searchTags": [ | ||
| "div", | ||
| "parent", | ||
| "group" | ||
| ], | ||
| "topRow": 0, | ||
| "bottomRow": 10, | ||
| "parentRowSpace": 10, | ||
| "type": "SECTION_WIDGET", | ||
| "hideCard": true, |
There was a problem hiding this comment.
Tip
Codebase Verification
Duplicate and empty widgetId values detected.
The verification script identified multiple instances of duplicate and empty widgetId values across various JSON files. Each widgetId should be unique and non-empty to avoid potential conflicts and ensure proper functionality.
- Ensure that all
widgetIdvalues are unique. - Replace empty
widgetIdvalues with valid, unique identifiers.
Files with issues:
app/client/cypress/fixtures/AllWidgetsDsl.jsonapp/client/cypress/fixtures/CommunityIssuesExport.jsonapp/client/cypress/fixtures/Bugs/CheckboxGroupInListWidgetDsl.jsonapp/client/cypress/fixtures/ButtonGroup_MenuButton_Width_dsl.jsonapp/client/cypress/fixtures/ContextSwitching.jsonapp/client/cypress/fixtures/ImportApps/JSOnLoadFailureTest.jsonapp/client/cypress/fixtures/ImportApps/JSOnLoadImport.jsonapp/client/cypress/fixtures/JSObjOnLoadApp.jsonapp/client/cypress/fixtures/JSObjectMutationTestApp.jsonapp/client/cypress/fixtures/ListVulnerabilityDSL.jsonapp/client/cypress/fixtures/ListWidgetWithDataAndButtonDSL.jsonapp/client/cypress/fixtures/Listv2/ListWithInputForSelectedAndTriggerRow.jsonapp/client/cypress/fixtures/Listv2/nestedList.jsonapp/client/cypress/fixtures/Listv2/simpleList.jsonapp/client/cypress/fixtures/Listv2/simpleListWithInputAndButton.jsonapp/client/cypress/fixtures/Listv2/simpleListWithLargeData.jsonapp/client/cypress/fixtures/Listv2/simpleListWithTabsWidget.jsonapp/client/cypress/fixtures/PgAdmindsl.jsonapp/client/cypress/fixtures/PropertyPaneSlashMenuBindings.jsonapp/client/cypress/fixtures/ResizeListDsl.jsonapp/client/cypress/fixtures/Table/TableFilterImportApp.jsonapp/client/cypress/fixtures/TableMigrationAppExported.jsonapp/client/cypress/fixtures/ThemeAppdsl.jsonapp/client/cypress/fixtures/anvilInlineButtonWidget.jsonapp/client/cypress/fixtures/anvilToolbarButtonWidget.jsonapp/client/cypress/fixtures/apiParallelDsl.jsonapp/client/cypress/fixtures/appNavigationTestingApp.jsonapp/client/cypress/fixtures/appNavigationTestingAppWithLongPageNamesAndTitle.jsonapp/client/cypress/fixtures/buttonGroupDsl.jsonapp/client/cypress/fixtures/conversionFrAutoLayoutDsl.jsonapp/client/cypress/fixtures/disabledWidgetsDsl.jsonapp/client/cypress/fixtures/dynamicHeightListDsl.jsonapp/client/cypress/fixtures/dynamicTabWidgetdsl.jsonapp/client/cypress/fixtures/editorContextdsl.jsonapp/client/cypress/fixtures/executeAction.jsonapp/client/cypress/fixtures/explorerHiddenWidgets.jsonapp/client/cypress/fixtures/exported-app.jsonapp/client/cypress/fixtures/exportedApp.jsonapp/client/cypress/fixtures/filePickerV2_reset_check_dsl.jsonapp/client/cypress/fixtures/forkedApp.jsonapp/client/cypress/fixtures/formWithtabdsl.jsonapp/client/cypress/fixtures/gitImport.jsonapp/client/cypress/fixtures/listRegression2Dsl.jsonapp/client/cypress/fixtures/listRegression3Dsl.jsonapp/client/cypress/fixtures/listRegressionDsl.jsonapp/client/cypress/fixtures/listV2ButtonsDsl.jsonapp/client/cypress/fixtures/listWidgetLintDsl.jsonapp/client/cypress/fixtures/listdsl.jsonapp/client/cypress/fixtures/listv2PaginationDsl.jsonapp/client/cypress/fixtures/menuButtonDsl.jsonapp/client/cypress/fixtures/modalWidgetTestApp.jsonapp/client/cypress/fixtures/one_postgres.jsonapp/client/cypress/fixtures/promisesBtnListDsl.jsonapp/client/cypress/fixtures/tabsDsl.jsonapp/client/cypress/fixtures/tabsWidgetDsl.jsonapp/client/cypress/fixtures/tabsWidgetReset.jsonapp/client/cypress/fixtures/tabsWithWidgetDsl.jsonapp/client/cypress/fixtures/videoWidgetApp.jsonapp/client/cypress/fixtures/widgetPopupDsl.jsonapp/client/cypress/fixtures/xmlParser.jsonapp/server/appsmith-git/src/test/resources/DSLWidget/AllWidgetsDSL.jsonapp/server/appsmith-git/src/test/resources/DSLWidget/TabWidgetNestedChildren.jsonapp/server/appsmith-server/src/main/resources/examples-organization.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/git/autocommit/application.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/git/autocommit/autocommit.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/git/ce-automation-test.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/imports/internal/faulty-dsl.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/migrations/application.jsonapp/server/appsmith-server/src/test/resources/test_assets/DSLMigration/PageDSLv83.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/building-block.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/invalid-application-without-pageId-action-collection.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-app-positioning.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-custom-themes.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-page-added.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-page-removed.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-un-configured-datasource.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-action-collection.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-app-layout.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-navigation-theme-setting.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-theme.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application.json
Analysis chain
Ensure widget properties are correctly defined.
The properties for the "Section2" widget seem consistent and complete. However, verify that the widgetId and other unique identifiers are correct and not duplicated elsewhere.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the widgetId and other unique identifiers are unique across the JSON file.
# Test: Check for duplicate widgetIds. Expect: No duplicates.
rg --type json '"widgetId":' | sort | uniq -d
Length of output: 109161
Comment on lines
+856
to
+871
| "needsErrorInfo": false, | ||
| "boxShadow": "NONE", | ||
| "mobileBottomRow": 10, | ||
| "widgetName": "Section3", | ||
| "isCanvas": true, | ||
| "displayName": "Section", | ||
| "searchTags": [ | ||
| "div", | ||
| "parent", | ||
| "group" | ||
| ], | ||
| "topRow": 0, | ||
| "bottomRow": 10, | ||
| "parentRowSpace": 10, | ||
| "type": "SECTION_WIDGET", | ||
| "hideCard": true, |
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure widget properties are correctly defined.
The verification has revealed multiple issues with widgetId values across the JSON files:
- Some
widgetIdvalues are empty. - Some
widgetIdvalues are set totrue. - There are duplicate
widgetIdvalues.
Please correct the following issues:
- Ensure all
widgetIdvalues are non-empty and valid strings. - Remove or replace any
widgetIdvalues set totrue. - Ensure each
widgetIdis unique across all JSON files.
Locations to address:
app/client/cypress/fixtures/AllWidgetsDsl.jsonapp/client/cypress/fixtures/Bugs/CheckboxGroupInListWidgetDsl.jsonapp/client/cypress/fixtures/ButtonGroup_MenuButton_Width_dsl.jsonapp/client/cypress/fixtures/CommunityIssuesExport.jsonapp/client/cypress/fixtures/DynamicHeightListTextDsl.jsonapp/client/cypress/fixtures/IframeOnSrcDocChange.jsonapp/client/cypress/fixtures/ImportApps/JSOnLoadFailureTest.jsonapp/client/cypress/fixtures/ImportApps/JSOnLoadImport.jsonapp/client/cypress/fixtures/JSObjOnLoadApp.jsonapp/client/cypress/fixtures/JSObjectMutationTestApp.jsonapp/client/cypress/fixtures/ListVulnerabilityDSL.jsonapp/client/cypress/fixtures/ListWidgetWithDataAndButtonDSL.jsonapp/client/cypress/fixtures/Listv2/ListWithInputForSelectedAndTriggerRow.jsonapp/client/cypress/fixtures/Listv2/nestedList.jsonapp/client/cypress/fixtures/Listv2/simpleList.jsonapp/client/cypress/fixtures/Listv2/simpleListWithInputAndButton.jsonapp/client/cypress/fixtures/Listv2/simpleListWithLargeData.jsonapp/client/cypress/fixtures/Listv2/simpleListWithTabsWidget.jsonapp/client/cypress/fixtures/PgAdmindsl.jsonapp/client/cypress/fixtures/PropertyPaneSlashMenuBindings.jsonapp/client/cypress/fixtures/ResizeListDsl.jsonapp/client/cypress/fixtures/Table/TableFilterImportApp.jsonapp/client/cypress/fixtures/TableFilterImportApp.jsonapp/client/cypress/fixtures/TableMigrationAppExported.jsonapp/client/cypress/fixtures/ThemeAppdsl.jsonapp/client/cypress/fixtures/anvilInlineButtonWidget.jsonapp/client/cypress/fixtures/anvilToolbarButtonWidget.jsonapp/client/cypress/fixtures/apiParallelDsl.jsonapp/client/cypress/fixtures/appNavigationTestingApp.jsonapp/client/cypress/fixtures/appNavigationTestingAppWithLongPageNamesAndTitle.jsonapp/client/cypress/fixtures/buttonGroupDsl.jsonapp/client/cypress/fixtures/conversionFrAutoLayoutDsl.jsonapp/client/cypress/fixtures/disabledWidgetsDsl.jsonapp/client/cypress/fixtures/dynamicHeightListDsl.jsonapp/client/cypress/fixtures/dynamicTabWidgetdsl.jsonapp/client/cypress/fixtures/editorContextdsl.jsonapp/client/cypress/fixtures/executeAction.jsonapp/client/cypress/fixtures/explorerHiddenWidgets.jsonapp/client/cypress/fixtures/exported-app.jsonapp/client/cypress/fixtures/exportedApp.jsonapp/client/cypress/fixtures/filePickerV2_reset_check_dsl.jsonapp/client/cypress/fixtures/forkedApp.jsonapp/client/cypress/fixtures/formWithtabdsl.jsonapp/client/cypress/fixtures/gitImport.jsonapp/client/cypress/fixtures/listRegression2Dsl.jsonapp/client/cypress/fixtures/listRegression3Dsl.jsonapp/client/cypress/fixtures/listRegressionDsl.jsonapp/client/cypress/fixtures/listV2ButtonsDsl.jsonapp/client/cypress/fixtures/listWidgetLintDsl.jsonapp/client/cypress/fixtures/listdsl.jsonapp/client/cypress/fixtures/listv2PaginationDsl.jsonapp/client/cypress/fixtures/menuButtonDsl.jsonapp/client/cypress/fixtures/modalWidgetTestApp.jsonapp/client/cypress/fixtures/widgetPopupDsl.jsonapp/client/cypress/fixtures/xmlParser.jsonapp/server/appsmith-git/src/test/resources/DSLWidget/AllWidgetsDSL.jsonapp/server/appsmith-git/src/test/resources/DSLWidget/TabWidgetNestedChildren.jsonapp/server/appsmith-server/src/main/resources/examples-organization.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/git/autocommit/application.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/git/ce-automation-test.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/imports/internal/faulty-dsl.jsonapp/server/appsmith-server/src/test/resources/com/appsmith/server/migrations/application.jsonapp/server/appsmith-server/src/test/resources/test_assets/DSLMigration/PageDSLv83.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/building-block.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/invalid-application-without-pageId-action-collection.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-app-positioning.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-custom-themes.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-page-added.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-page-removed.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-un-configured-datasource.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-with-page-added.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-action-collection.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-app-layout.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-navigation-theme-setting.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application-without-theme.jsonapp/server/appsmith-server/src/test/resources/test_assets/ImportExportServiceTest/valid-application.json
Analysis chain
Ensure widget properties are correctly defined.
The properties for the "Section3" widget seem consistent and complete. However, verify that the widgetId and other unique identifiers are correct and not duplicated elsewhere.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the widgetId and other unique identifiers are unique across the JSON file.
# Test: Check for duplicate widgetIds. Expect: No duplicates.
rg --type json '"widgetId":' | sort | uniq -d
Length of output: 109161
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9776733132. |
|
Deploy-Preview-URL: https://ce-34639.dp.appsmith.com |
2 tasks
KelvinOm
added a commit
that referenced
this pull request
Jul 9, 2024
## Description 1. Add scripts for local e2e testing in the docker container. 2. Add types for cypress-image-snapshot In this PR, I also added the following PRS as they affect screenshot tests as well. I did this to speed up the process and unblock the team. #34528 #34546 #34676 #34729 #34638 #34639 #34511 To run E2E tests locally in docker, you need to do the following: 1. Run FE locally and prepare the tests for local launch. See the instructions [here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md). 2. Run `yarn cypress:snapshot:docker:build` — this will create a docker container with the necessary environment. 3. Run `yarn cypress:snapshot:docker "./cypress/e2e/Regression/ClientSide/Anvil/Widgets/*_spec.ts" updateSnapshots=false`. Here we can use the path to a specific file, or set `updateSnapshots=true` flag to update the screenshots. ## Automation /ok-to-test tags="@tag.Anvil" ### :mag: Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9844579277> > Commit: 75f2659 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9844579277&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 08 Jul 2024 18:37:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for image snapshot testing with the `@types/cypress-image-snapshot` dependency. - **Refactor** - Updated test specifications by removing unnecessary `triggerInputInvalidState()` calls. - Reorganized and improved efficiency of image snapshot methods for various devices. - **Chores** - Updated `Dockerfile` to configure the Cypress environment with specific versions for dependencies. - Changed import paths in `e2e.js` for better module resolution. - **Style** - Fixed a comment typo in Cypress plugin configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: unknown <[email protected]>
|
Merged here. |
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this pull request
Jul 10, 2024
## Description 1. Add scripts for local e2e testing in the docker container. 2. Add types for cypress-image-snapshot In this PR, I also added the following PRS as they affect screenshot tests as well. I did this to speed up the process and unblock the team. appsmithorg#34528 appsmithorg#34546 appsmithorg#34676 appsmithorg#34729 appsmithorg#34638 appsmithorg#34639 appsmithorg#34511 To run E2E tests locally in docker, you need to do the following: 1. Run FE locally and prepare the tests for local launch. See the instructions [here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md). 2. Run `yarn cypress:snapshot:docker:build` — this will create a docker container with the necessary environment. 3. Run `yarn cypress:snapshot:docker "./cypress/e2e/Regression/ClientSide/Anvil/Widgets/*_spec.ts" updateSnapshots=false`. Here we can use the path to a specific file, or set `updateSnapshots=true` flag to update the screenshots. ## Automation /ok-to-test tags="@tag.Anvil" ### :mag: Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9844579277> > Commit: 75f2659 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9844579277&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 08 Jul 2024 18:37:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for image snapshot testing with the `@types/cypress-image-snapshot` dependency. - **Refactor** - Updated test specifications by removing unnecessary `triggerInputInvalidState()` calls. - Reorganized and improved efficiency of image snapshot methods for various devices. - **Chores** - Updated `Dockerfile` to configure the Cypress environment with specific versions for dependencies. - Changed import paths in `e2e.js` for better module resolution. - **Style** - Fixed a comment typo in Cypress plugin configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: unknown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit