Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved Incomplete error message for Rating widget #30675

Closed
wants to merge 1 commit into from

Conversation

SanjanaSingh3
Copy link

@SanjanaSingh3 SanjanaSingh3 commented Jan 28, 2024

Incomplete error message for Rating widget #17654

Description

When the Allow Half Stars property is turned off and the user enters a decimal value for the Default Rating, an incomplete error message is displayed.

PR fixes following issue(s)

Fixes # 17654

  • Bug Fixes
    • Updated the error message in the Rate Widget for clearer guidance on allowing half stars.

completed error message for Rating widget
Copy link

welcome bot commented Jan 28, 2024

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

Copy link
Contributor

coderabbitai bot commented Jan 28, 2024

Walkthrough

Walkthrough

The modification pertains to enhancing a user-facing error message within the Rate Widget. Specifically, the update refines the guidance provided when validating the default rate setting, clarifying that half stars are permissible by changing the error message to explicitly mention "Allow half stars" instead of the more ambiguous "Allow half."

Changes

File Path Change Summary
app/client/src/widgets/.../index.tsx Updated error message in validateDefaultRate to specify "Allow half stars".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@SanjanaSingh3 SanjanaSingh3 changed the title Update index.tsx fix:Update index.tsx Jan 29, 2024
@SanjanaSingh3 SanjanaSingh3 changed the title fix:Update index.tsx fix: Resolve Incomplete error message for Rating widget #17654 Jan 30, 2024
@SanjanaSingh3 SanjanaSingh3 changed the title fix: Resolve Incomplete error message for Rating widget #17654 fix: Resolve Incomplete error message for Rating widget Jan 30, 2024
@SanjanaSingh3 SanjanaSingh3 changed the title fix: Resolve Incomplete error message for Rating widget fix: Resolved Incomplete error message for Rating widget Jan 30, 2024
Copy link

github-actions bot commented Feb 6, 2024

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Feb 6, 2024
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant