Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: If we click on the commit icon of a github connected app on airgapped, the app crashes. #33812

Open
1 task done
btsgh opened this issue May 29, 2024 · 3 comments · May be fixed by #34673
Open
1 task done

[Bug]: If we click on the commit icon of a github connected app on airgapped, the app crashes. #33812

btsgh opened this issue May 29, 2024 · 3 comments · May be fixed by #34673
Assignees
@brayn003
Labels
Airgap Tickets related to supporting air-gapped Appsmith instances Bug Something isn't working Git Pod Anything related to git sync Git Version Control Issues related to version control High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Team Managers Pod Issues that team managers care about for the security and efficiency of their teams

Comments

@btsgh
Copy link

btsgh commented May 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

I have a git connected app connecting to a github repository [connected with internet], then go offline and click on the commit button - the app crashes.
Expected behavior - app should not crash - this scenario should be handled gracefully

Steps To Reproduce

  1. Create an app on airgapped
  2. Go online
  3. Connect to git hub repository
  4. Now go offline
  5. Open the above app
  6. Click on the commit button
    App crashes.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Airgapped
@btsgh btsgh added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Production Needs Triaging Needs attention from maintainers to triage Git Version Control Issues related to version control Airgap Tickets related to supporting air-gapped Appsmith instances labels May 29, 2024
@github-actions github-actions bot added Team Managers Pod Issues that team managers care about for the security and efficiency of their teams Git Pod Anything related to git sync labels May 29, 2024
@btsgh
Copy link
Author

btsgh commented May 29, 2024

Screen.Recording.2024-05-29.at.12.08.13.PM.mov

VigneswarV added a commit to VigneswarV/appsmith that referenced this issue Jul 3, 2024
@VigneswarV
fix: commit icon github app crashes appsmithorg#33812
7324a18 
Page crashes happened because of null pointer exception from front-end code, fixed that one.
@VigneswarV VigneswarV linked a pull request Jul 3, 2024 that will close this issue
Open
@VigneswarV
Copy link

I have Fixed and created a PR for this
#34673

@akshayvijayjain
Copy link

@brayn003 @btsgh Please help with reviewer for the pr #34673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

Labels
Airgap Tickets related to supporting air-gapped Appsmith instances Bug Something isn't working Git Pod Anything related to git sync Git Version Control Issues related to version control High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: commit icon of github on airgapped, the app crashes. #33812 VigneswarV/appsmith
4 participants
@brayn003 @btsgh @VigneswarV @akshayvijayjain