Add Appsignal.configure .env? helper #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding environment specific config with an if-statement comparing the current environment, they need to use a String. If apps compare a String with a Symbol like `config.env == :production` it would return false. Apps can call `Appsignal.configure(:production)` with a Symbol and we'll cast it to a String. The environment in the Config class is always a String. Add the `config.env?` helper to handle the casting of the environment value so that our users don't have to bother with casting the environment value to a String.
unflxw
approved these changes
Nov 12, 2024
jeffkreeftmeijer
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding environment specific config with an if-statement comparing the current environment, they need to use a String. If apps compare a String with a Symbol like
config.env == :productionit would return false.Apps can call
Appsignal.configure(:production)with a Symbol and we'll cast it to a String. The environment in the Config class is always a String.Add the
config.env?helper to handle the casting of the environment value so that our users don't have to bother with casting the environment value to a String.