Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Appsignal.set_empty_params! helper method #1332

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

tombruijn
Copy link
Member

Fix API docs for Appsignal.configure method

I renamed this argument and didn't update the docs.

Document Appsignal.set_empty_params! helper method

Make this method public now that we've had someone ask for it. Previously it was kept private because we were the only ones using it and I wasn't quite sure of the implementation. I don't know of a better implementation so let's make it public.

I renamed this argument and didn't update the docs.
Make this method public now that we've had someone ask for it.
Previously it was kept private because we were the only ones using it
and I wasn't quite sure of the implementation. I don't know of a better
implementation so let's make it public.
Fix typo in the example module name.
Copy link
Contributor

@stefanvermaas stefanvermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@tombruijn tombruijn merged commit e4dbbdb into main Nov 11, 2024
124 checks passed
@tombruijn tombruijn deleted the public-empty-params branch November 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants