Fix Pathname to String conversion error #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails apps the app root path is a Pathname instance. We can't use it the same way as a String when using it in `.start_with?` when comparing backtrace lines for error causes in `Transaction#first_formatted_backtrace_line`. Fix this by casting the root_path always to a String in the Config initializer so we're always sure it's a String and can use it as such.
tombruijn
force-pushed
the
fix-pathname-conversion
branch
from
50eb951
to
3000fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails apps the app root path is a Pathname instance. We can't use it the same way as a String when using it in
.start_with?when comparing backtrace lines for error causes inTransaction#first_formatted_backtrace_line.Fix this by casting the root_path always to a String in the Config initializer so we're always sure it's a String and can use it as such.
[skip review]