Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config env, root path and options read only #1308

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Make config env, root path and options read only #1308

merged 3 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Refactor specs to not modify config after init 

    Do like the actual apps that use AppSignal and don't modify the config
after it's initialized. Set the config options using the `build_config`
helper instead.
    @tombruijn
    tombruijn committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c840901 View commit details
    Browse the repository at this point in the history

  2. Improve docs for config sources API 

    The attribute docs were out of date and didn't cover all the attributes.
Instead give them the same docs for all source attributes.
    @tombruijn
    tombruijn committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    58d1e08 View commit details
    Browse the repository at this point in the history

  3. Make config env, root path and options read only 

    Not sure why these were an accessor, but they don't need to define
writers to allow app to overwrite the config after AppSignal has
started. That can cause problems and expectations that the changed
config is picked up.

[skip changeset] as these are private APIs.
    @tombruijn
    tombruijn committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    79a2942 View commit details
    Browse the repository at this point in the history