Fix all_specs deprecation of bundler #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundler deprecated the usage of `Bundler.rubygems.all_specs` with version 2.5.12 (June 13, 2024), in order to better support default gems. This version is the new default version with ruby 3.3.3 and thus the warning pops up: Bundler.rubygems.all_specs has been removed in favor of Bundler.rubygems.installed_specs
Fix the indenting to make RuboCop happy.
Update copy before merging the PR.
|
Thanks for the quick merge and small style fixes! |
tombruijn
added a commit
that referenced
this pull request
Aug 26, 2024
Follow up of #1159 Silence the warning about calling an deprecated method because it confuses me when I read the spec output. Test against the new method as well.
tombruijn
added a commit
that referenced
this pull request
Aug 26, 2024
Follow up of #1159 Silence the warning about calling an deprecated method because it confuses me when I read the spec output. Test against the new method as well.
tombruijn
added a commit
that referenced
this pull request
Aug 26, 2024
Follow up of #1159 Silence the warning about calling an deprecated method because it confuses me when I read the spec output. Test against the new method as well.
tombruijn
added a commit
that referenced
this pull request
Aug 26, 2024
Follow up of #1159 Silence the warning about calling an deprecated method because it confuses me when I read the spec output. Test against the new method as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundler deprecated the usage of
Bundler.rubygems.all_specswith version 2.5.12 (June 13, 2024), in order to better support default gems.This version is the new default version with ruby 3.3.3 and thus the warning pops up:
Bundler.rubygems.all_specs has been removed in favor of Bundler.rubygems.installed_specs