Reverted Pylint from 1.9.5 to 1.9.4 because of PyPI error #285
Conversation
Using Pip 20.2.3 ``` pip install pylint==1.9.5ERROR: Could not find a version that satisfies the requirement pylint==1.9.5 (from versions: 0.15.2, 0.16.0, 0.18.0, 0.18.1, 0.19.0, 0.20.0, 0.21.0, 0.21.1, 0.21.2, 0.21.3, 0.22.0, 0.23.0, 0.24.0, 0.25.0, 0.25.1, 0.25.2, 0.26.0, 0.27.0, 0.28.0, 1.0.0, 1.1.0, 1.2.0, 1.2.1, 1.3.0, 1.3.1, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7.0, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.7.6, 1.8.0, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 2.0.0.dev0, 2.0.0.dev1, 2.0.0.dev2, 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.3.0.dev0, 2.3.0.dev1, 2.3.0.dev2, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0)ERROR: No matching distribution found for pylint==1.9.5 ``` Even though Pylint 1.9.5 seems to exist in PyPI This commit also updates the Makefile `python.clean` target to remove `__pycache__` directories from the `figures` package source directory hierarchy.
There was a problem hiding this comment.
FWIW, this is probably because Pylint 1.9.5 is restricted to: Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, <3.7 while 1.9.4 is Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*. So my guess is that the environment that's installing it is Python 3.8. Basically, 1.9.4 probably isn't really tested against 3.8, but their restriction was overly lax and so it can sneak through. On 1.9.5 they added the <3.7 restriction so now pip is correctly avoiding installing it.
Have you tried upgrading to a version of Pylint that properly supports Python3?
(with something like Pylint though, I'm not too concerned. If a version works, it works)
|
@thraxil Thanks! I'll make a "TODO" to upgrade Figures tox lint tests to use Py 3.x. And you're 100% right. I created a Py 3.9 env instead of a Python 2.7 env. Could be a side effect of mucking around with PyEnv trying to get Python 3.5 working on my Mac |
|
Created issue: #286 |
|
Hmm, since the reason it failed was because I wrongly ran it in Python 3.9 instead of Python 2.7, I'm going to close this PR and create a new one just for the Makefile pycache cleanup |
Using Pip 20.2.3
Even though Pylint 1.9.5 seems to exist in PyPI
This commit also updates the Makefile
python.cleantarget to remove__pycache__directories from thefigurespackage source directoryhierarchy.