-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Golang rewrite #83
Open
JohnMurray
wants to merge
10
commits into
master
Choose a base branch
from
golang-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Golang rewrite #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an in-progress commit of a rewrite of the schema tool to be in Go. This is mainly a major cleanup of the tooling but also an effort to simplify the distribution by being able to rely on single-binary releases. The rewrite also intends to change the internal model to allow for better exensibility and integration with other tooling. This commit represents a cleanup of several initial commits and does not consitute a working or complete rewrite of the tooling. It does however include a compilable CLI, a working web-server, some initial tests, scripts for licensing, and a usable Makefile along with some other supporting code necessary for the port.
Cleanup of all 'lib' aspects of the code. Mainly fixing all linter warnings and properly documenting the code. Also moving chain and log into the lib/ folder to match the other convention of using cmd/ and server/
Needed to download and install dep and run 'dep ensure' on install
Lib Cleanup
Still missing a full release process (and actual binaries to download) but the docs are updated now to reflect what _will_ be the new install process
Updated install documentation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
========================================
Coverage ? 52.5%
========================================
Files ? 1
Lines ? 200
Branches ? 0
========================================
Hits ? 105
Misses ? 90
Partials ? 5
Continue to review full report at Codecov.
|
Resulting from running meta-linter on Travis, some fixes were in order.
Travis Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-lived PR as the tooling is re-written to GoLang. Opening a PR for visibility.
Further work on this branch will happen in other branches with PRs into the
golang-rewrite
branch.