Feature #854 innermost ip randomization staging

[fklassen]

No description provided.

[jasonlue]

I have a local version that passed all the tests. Will try another time

[fklassen]

I have a local version that passed all the tests. Will try another time

I must of messed up with the merge into 4.5.0. You think you can get this done in the next week or so? If so, I'll hold of 4.5.0 release, and create a 4.5.0-beta3 to get some soak time.

[jasonlue]

I'll give it a try again this weekend

[fklassen]

I am also considering working on your PR's this weekend. If you want to colaberate contact me at tcpreplay at appneta dot com.

[jasonlue]

The MR itself is against the master. and that MR passed all the tests. I guess the merge into 4.5.0-beta3 might introduce some issues but need to compare them.

[fklassen]

Then let me hava a look at it and see what is going wrong. Note that many CVEs have been fixed in this area, and every peek into a packet must be tested for overruns. Otherwise we will have a new round of bugs opened against this PR.

[fklassen]

I included #853 to 4.5.0-beta3 and will let it sit there a about a week so people can test.

Although I would like to see this one go this release, I feel it should go into the next one. But I want to check with you first. If you have been working on this and will have it done soon, I may consider extending 4.5.0 release.

I'm not sure if you want to take this on, or if you want me to. I would like to see:

• all the tests pass (may need to update test result files if new results are superior)
• some kind of option that lets someone select level
  • e.g. --unique-ip-level which accepts a number, inner, outer etc. Default is probable outer.

[jasonlue]

It's fine to go to the next release, giving more time for feedback, and to figure tests out. --unique-ip-level is a good idea. I can add it in relatively easily.