Skip to content

Commit

Permalink
Extend gray failure recentHealthTriggeredRecoveryTime state to reflec…
Browse files Browse the repository at this point in the history
…t any recovery, including non-gray failure triggered ones
  • Loading branch information
spraza committed Dec 17, 2024
1 parent 248e6e7 commit 1cd2a88
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fdbserver/ClusterController.actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ ACTOR Future<Void> clusterWatchDatabase(ClusterControllerData* cluster,
SERVER_KNOBS->SECONDS_BEFORE_NO_FAILURE_DELAY
: SERVER_KNOBS->MASTER_FAILURE_SLOPE_DURING_RECOVERY) ||
db->forceMasterFailure.onTrigger())) {
cluster->recentHealthTriggeredRecoveryTime.push(now());
break;
}
when(wait(db->serverInfo->onChange())) {}
Expand Down Expand Up @@ -3061,7 +3062,6 @@ ACTOR Future<Void> workerHealthMonitor(ClusterControllerData* self) {
if (self->shouldTriggerRecoveryDueToDegradedServers()) {
if (SERVER_KNOBS->CC_HEALTH_TRIGGER_RECOVERY) {
if (self->recentRecoveryCountDueToHealth() < SERVER_KNOBS->CC_MAX_HEALTH_RECOVERY_COUNT) {
self->recentHealthTriggeredRecoveryTime.push(now());
self->excludedDegradedServers.clear();
for (const auto& degradedServer : self->degradationInfo.degradedServers) {
self->excludedDegradedServers[degradedServer] = now();
Expand Down

0 comments on commit 1cd2a88

Please sign in to comment.