Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Variables as colorpicker inputs #4818

Merged
merged 18 commits into from
Dec 5, 2024
Merged

Conversation

stuartromanek
Copy link
Member

@stuartromanek stuartromanek commented Dec 4, 2024

Summary

  • Adds the capability to supply CSS variable names as a selectable color swatches in the AposColor input type

Testbed

What are the specific steps to test this change?

  • Checkout public-demo#color-var-demo
  • The Global schema is configured with a Color Picker Test field. See that all the swatches are populated. Use them. Change them. Make sure they act right. Make sure the setting persists.
  • Rich Text widgets on the homepage are also configured to use the color picker via TipTap. Set a piece of text to a color using a variable. Make sure the setting persists.
image

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

@stuartromanek stuartromanek marked this pull request as ready for review December 4, 2024 20:18
Copy link
Contributor

@BoDonkey BoDonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tests fine and code is sane.

@stuartromanek stuartromanek merged commit 9c6b6bb into main Dec 5, 2024
9 checks passed
@stuartromanek stuartromanek deleted the colorpicker/variables branch December 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants