PRO-6835: Determine Best AssetUrl is in easy mode with the new build system #4814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new build system (when external build module is self-registered) doesn't need any computations about "what is the override of a given module". The asset override is done on
fs
level and the path doesn't need "my-*" prefix in the URL. However, the legacy Webpack system still needs the computations. This patch fixes it all in a BC way.What are the specific steps to test this change?
Override a preview image for
@apostrophecms/image-widget
inmodules/@apostrophecms/image-widget/public/preview.jpg
(project level).When no external build module (Vite) is registered the preview will be resolved (and properly shown) to:
When external build module (Vite) IS registered the preview will be resolved (and properly shown) to:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: